Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with deep linking #6688

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Fix regression with deep linking #6688

merged 1 commit into from
Apr 30, 2019

Conversation

tmeasday
Copy link
Member

Issue: #5925

The issue was the iframe did not update when its src was changed as we navigated to the story id.

The reason it sometimes worked depended on whether the preview had set up its channel in time (the event was emitted).

What I did

Ensured the preview's URL changed.

How to test

http://localhost:9011/?selectedKind=UI%7CPanel&selectedStory=no+panels

@vercel
Copy link

vercel bot commented Apr 30, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-5925-fix-kind-deep-linking.storybook.now.sh

@tmeasday tmeasday added bug patch:yes Bugfix & documentation PR that need to be picked to main branch ui labels Apr 30, 2019
@tmeasday tmeasday mentioned this pull request Apr 30, 2019
Closed
shilman
shilman approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - fixed the same bug in the Docs work 😭

@shilman shilman merged commit a1511ab into next Apr 30, 2019
@shilman shilman deleted the 5925-fix-kind-deep-linking branch April 30, 2019 08:33
@lewisl9029 lewisl9029 mentioned this pull request May 11, 2019
Closed
ndelangen
ndelangen reviewed May 13, 2019
View reviewed changes
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause refreshes in the preview, as any change the an iframe's src will cause it to refresh

@tmeasday
Copy link
Member Author

We should probably revert this PR and figure out what is wrong with the existing buffer in the postmessage channel

@tmeasday
Copy link
Member Author

Also we should make it more explicit in the IFrame component that src should not change

@ndelangen ndelangen mentioned this pull request May 14, 2019
Merged
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen left review comments

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmeasday @shilman @ndelangen